Move some classes to new bridging library#33413
Closed
appden wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34723341 |
|
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34723341 |
appden
force-pushed
the
export-D34723341
branch
from
63d5faa to
6b2be4b
Compare
appden
force-pushed
the
export-D34723341
branch
from
6b2be4b to
b95f59b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34723341 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34723341 |
appden
force-pushed
the
export-D34723341
branch
from
b95f59b to
5741e41
Compare
Base commit: 2829146 |
Summary: Pull Request resolved: facebook#33413 This moves `CallbackWrapper` and `LongLivedObject` into a new "bridging" library. This library is mostly intended for use by the native module system, but can also be used separately to "bridge" native and JS interfaces through higher-level (and safer) abstractions than relying JSI alone. Changelog: Internal Reviewed By: christophpurrer Differential Revision: D34723341 fbshipit-source-id: c32953b8d8c963cf4e012fb60677e9fc71f81dba
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34723341 |
appden
force-pushed
the
export-D34723341
branch
from
5741e41 to
3f88c57
Compare
Base commit: 2829146 |
Collaborator
|
This pull request was successfully merged by @appden in 6a9497d. When will my fix make it into a release? | Upcoming Releases |
Saadnajmi
pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Jan 15, 2023
Summary: Pull Request resolved: facebook#33413 This moves `CallbackWrapper` and `LongLivedObject` into a new "bridging" library. This library is mostly intended for use by the native module system, but can also be used separately to "bridge" native and JS interfaces through higher-level (and safer) abstractions than relying JSI alone. Changelog: Internal Reviewed By: christophpurrer Differential Revision: D34723341 fbshipit-source-id: 7ca8fa815537152f8163920513b90313540477e3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This moves
CallbackWrapperandLongLivedObjectinto a new "bridging" library. This library is mostly intended for use by the native module system, but can also be used separately to "bridge" native and JS interfaces through higher-level (and safer) abstractions than relying JSI alone.Changelog:
Internal
Reviewed By: christophpurrer
Differential Revision: D34723341